Fails to build with gcc

[elfringham]

Build fails with following error due to code that is protected by ifdef for LLVM presence being referenced by code that is not so protected.

/home/andrew/src/tvm/src/target/metadata_module.cc: In function ‘tvm::runtime::Module tvm::codegen::CreateMetadataModule(const std::unordered_map<std::__cxx11::basic_string, tvm::runtime::NDArray>&, tvm::runtime::Module, const tvm::runtime::Arraytvm::runtime::Module&, tvm::Target)’:
/home/andrew/src/tvm/src/target/metadata_module.cc:120:23: error: ‘CreateLLVMCrtMetadataModule’ was not declared in this scope
target_module = CreateLLVMCrtMetadataModule(crt_exportable_modules, target);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/tvm/src/target/metadata_module.cc:120:23: note: suggested alternative: ‘CreateCSourceCrtMetadataModule’
target_module = CreateLLVMCrtMetadataModule(crt_exportable_modules, target);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
CreateCSourceCrtMetadataModule
make[3]: *** [CMakeFiles/tvm_objs.dir/build.make:2071: CMakeFiles/tvm_objs.dir/src/target/metadata_module.cc.o] Error 1
make[3]: Leaving directory '/home/andrew/src/tvm/build'
make[2]: *** [CMakeFiles/Makefile2:130: CMakeFiles/tvm_objs.dir/all] Error 2
make[2]: Leaving directory '/home/andrew/src/tvm/build'
make[1]: *** [Makefile:149: all] Error 2
make[1]: Leaving directory '/home/andrew/src/tvm/build'
make: *** [Makefile:43: all] Error 2

[elfringham]

On 10/03/2021 07:53, Junru Shao wrote: This method is defined in |src/target/llvm/llvm_module.h|. Would you like to double check if it is properly included? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7618 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACPVKEJH36J5S7B4HOQ36JLTC4JN7ANCNFSM4Y3GCH2Q>.

The code in |src/target/llvm/llvm_module.h| is surrounded by #ifdef TVM_LLVM_VERSION The code that references CreateLLVMCrtMetadataModule in src/target/metadata_module.cc is not surrounded by that #define. In my build that #define is not defined => build failure. Andrew

[tqchen]

Thanks @elfringham , should be fixed by #7621