Add @slow decorator to run tests on main
#10057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu,
zhiics and
a team
as code owners
driazati
force-pushed
the
slow_dec
branch
4 times, most recently
from
e7ab449
to
2091729
Compare
|
Hi @driazati, Can you recreate your RFC in |
done! apache/tvm-rfcs#55 |
areusch
reviewed
Jan 27, 2022
driazati
force-pushed
the
slow_dec
branch
2 times, most recently
from
4e78a0d
to
38c7ba9
Compare
3 tasks
Mousius
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
apache/tvm-rfcs#55 is now merged, I'm going to leave this with @areusch to merge if happy 😸
4 tasks
|
@driazati it looks like it's merge cornflakes this morning 😿 if you rebase I can kick off a branch build for you. |
This adds the infrastructure discussed in https://discuss.tvm.apache.org/t/rfc-ci-skip-slow-tests-on-prs/11910, but without affecting any tests. As we investigate reasons behind [slow tests](https://gist.github.com/driazati/e009f09ff44c6bc91c4d95a8e17fd6f1) in CI, this decorator will allow us to move these to run only on `main` and not PRs after checking with all concerned parties.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* Add @slow decorator to run tests on `main` This adds the infrastructure discussed in https://discuss.tvm.apache.org/t/rfc-ci-skip-slow-tests-on-prs/11910, but without affecting any tests. As we investigate reasons behind [slow tests](https://gist.github.com/driazati/e009f09ff44c6bc91c4d95a8e17fd6f1) in CI, this decorator will allow us to move these to run only on `main` and not PRs after checking with all concerned parties. * cleanup Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the infrastructure discussed in https://discuss.tvm.apache.org/t/rfc-ci-skip-slow-tests-on-prs/11910, but without affecting any tests. As we investigate reasons behind slow tests in CI, this decorator will allow us to move these to run only on
mainand not PRs after checking with all concerned parties.To run slow tests on a PR, the PR body needs to have
@ci run slow tests(or similar, seeshould_run_slow_tests.py) in it somewhere. Skipping slow tests is a positive-only check, so they have to be explicitly skipped rather than run (meaning that for local runs no workflow change is necessary, slow tests will run as before)