Add more logging information to ReshapeLikeRel #10125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyken17
requested review from
anijain2305,
icemelon,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
|
Overall looks good! Let’s fix the lint and get this PR merged soon! |
|
@junrushao1994 @lhutton1 Lint error has been fixed. Please have a check. |
junrushao
approved these changes
Feb 2, 2022
|
Thanks @Lyken17 |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* Update transform.cc * fix capitalize * fix lint * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is shape mismatch, current logging only raises error but failed to provide detailed tensor shape information, which makes the bug localization difficult. This PR aims to add tensor_shape information when raising errors.