TVMC: Don't divide trials by zero tasks #10164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leandron @comaniac @junrushao1994, could you review this? :) |
leandron
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
LGTM, thanks @mkroening! Happy yo have this merged once CI is green.
|
@mkroening you'll need to trigger CI again, as it crashed with something that is not related to your PR, AFAIK. |
mkroening
force-pushed
the
tvmc-no-tasks
branch
from
4d02d6f
to
5649be1
Compare
If there are no tasks to tune, the number of trails is meaningless.
mkroening
force-pushed
the
tvmc-no-tasks
branch
from
5649be1
to
68867f2
Compare
|
@leandron, after two more tries, CI is green now. |
|
Thanks @mkroening, this is merged now! |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
If there are no tasks to tune, the number of trails is meaningless. Co-authored-by: Martin Kröning <martin.kroening@neclab.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9657.
If there are no tasks to tune, the number of trails are meaningless.