[TIR][Schedule] Opaque block does not satisfy stage-pipeline #10166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hzfengsy
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
kparzysz-quic,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
ZihengJiang
as code owners
MasterJH5574
approved these changes
Feb 4, 2022
|
If users write an opaque block and try to do transformations on it, we will not raise any schedule error but only provide error results. |
Hzfengsy
force-pushed
the
opaque_block_not_stage_pipeline
branch
from
0cb2f8d
to
54ef2f5
Compare
|
Any updates? |
1 similar comment
|
Any updates? |
|
Let's close this PR since it might need a generic solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage pipeline property requires all stmts in scope are schedulable stmts, which means opaque block (block without block vars) does not satisfy the property.
This PR fixes the bug.
cc @junrushao1994 @spectrometerHBH