Skip tensorflow test test_forward_ssd
#10231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
requested review from
comaniac,
junrushao,
tqchen,
jroesch,
areusch,
yzhliu,
merrymercy and
icemelon
as code owners
masahi
approved these changes
Feb 12, 2022
Since this test is launched in a thread, errors aren't propagated up to the main thread and thusly pytest doesn't detect / report them, so this test will always succeed. Given that this single test can take [upwards of 30 minutes](https://ci.tlcpack.ai/job/tvm/job/main/2499/testReport/cython.tests.python.frontend.tensorflow/test_forward/), this PR disables it until someone lands a proper fix (given that this test takes so long some consideration should be given to reducing its runtime before enabling it again).
junrushao
approved these changes
Feb 12, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
Since this test is launched in a thread, errors aren't propagated up to the main thread and thusly pytest doesn't detect / report them, so this test will always succeed. Given that this single test can take [upwards of 30 minutes](https://ci.tlcpack.ai/job/tvm/job/main/2499/testReport/cython.tests.python.frontend.tensorflow/test_forward/), this PR disables it until someone lands a proper fix (given that this test takes so long some consideration should be given to reducing its runtime before enabling it again). Co-authored-by: driazati <driazati@users.noreply.github.com>
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Since this test is launched in a thread, errors aren't propagated up to the main thread and thusly pytest doesn't detect / report them, so this test will always succeed. Given that this single test can take [upwards of 30 minutes](https://ci.tlcpack.ai/job/tvm/job/main/2499/testReport/cython.tests.python.frontend.tensorflow/test_forward/), this PR disables it until someone lands a proper fix (given that this test takes so long some consideration should be given to reducing its runtime before enabling it again). Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this test is launched in a thread, errors aren't propagated up to the main thread and thusly pytest doesn't detect / report them, so this test will always succeed. Given that this single test can take upwards of 30 minutes, this PR disables it until someone lands a proper fix (given that this test takes so long some consideration should be given to reducing its runtime before enabling it again).
cc @masahi @areusch @hpanda-naut