[fix] Convert BufferSlice to BufferLoad when used as range/loop start and end #10370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzh119
requested review from
comaniac,
junrushao,
tqchen,
jroesch,
areusch,
yzhliu,
merrymercy,
icemelon and
zhiics
as code owners
MasterJH5574
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
LGTM! Thank you Zihao!
A deeper question is should we make
BufferSliceaPrimExpr?
cc @spectrometerHBH @Hzfengsy. Could you guys reason about it 👀 ?
junrushao
approved these changes
Feb 25, 2022
|
Thanks @yzh119!! |
junrushao
pushed a commit
that referenced
this pull request
Mar 13, 2022
This is a tiny fix on the roundtrip test, the case test I introduced in #10370 doesn't use `tvm.testing.parameter`.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…nge/loop start and end (apache#10370) A quick fix of the parser issue mentioned in apache#10327 . Ranges and loops require `start` and `stop` to be PrimExpr, however, `BufferSlice` is not always scalar so it's not a `PrimExpr`. This PR performs the transformation.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
This is a tiny fix on the roundtrip test, the case test I introduced in apache#10370 doesn't use `tvm.testing.parameter`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix of the parser issue mentioned in #10327 .
Ranges and loops require
startandstopto be PrimExpr, however,BufferSliceis not always scalar so it's not aPrimExpr.This PR performs the transformation.
A deeper question is should we make
BufferSliceaPrimExpr?CC @MasterJH5574 @Hzfengsy