Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci][COMMUNITY] leandron to PMC #10448

Merged
merged 1 commit into from Mar 3, 2022
Merged

[skip-ci][COMMUNITY] leandron to PMC #10448

merged 1 commit into from Mar 3, 2022

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Mar 2, 2022

Dear community:

Please join us to welcome @leandron as a new PMC member. Leandro was one of the early contributors to the community. He contributed to the TVM command line driver.

He helps the community a lot by contributing to the CI and packaging efforts. Many of those efforts (time spent on overall coordination and infra) are not part of code contributions, nor do they necessary show up in normal code contribution statistics. But they are also very important for the TVM community (per our community guideline, "area of contribution can take all forms").

Importantly, leandro interacts constructively with the current community members in apache way.
Many interactions with Leandro with positive exchanges, with him being receptive to feedback and bringing constructive suggestions.

@masahi
Copy link
Member

masahi commented Mar 2, 2022

Need to undo the pylint change. We can do [skip-ci] for a PR like this. (Add [skip-ci] to the beginning of the PR title and commit message)

@tqchen tqchen changed the title [COMMUNITY] leandron to PMC [skip-ci][COMMUNITY] leandron to PMC Mar 2, 2022
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats Leandro!
[skip ci] seems only effective when opening the PR at the first time. Change the PR title or commit message after opening the PR might not work.

@masahi
Copy link
Member

masahi commented Mar 2, 2022

I think we need to change the title before pushing commit? cc @driazati

@masahi
Copy link
Member

masahi commented Mar 2, 2022

[skip ci] seems only effective when opening the PR at the first time. Change the PR title or commit message after opening the PR might not work

I remember doing [skip ci] "after the fact". #10067

@masahi
Copy link
Member

masahi commented Mar 2, 2022

maybe @tqchen can push another commit to be sure. It should finish after sanity check.

@driazati
Copy link
Member

driazati commented Mar 2, 2022

@masahi is right, both the commit message and the PR title at the time the build is run have to start with [skip ci] (so you need to re-push the commit so the check runs again). We're working on a glob-based approach for auto-skipping CI for certain files (e.g. *.md) soon that should obviate the need for this though: #10456

@masahi masahi merged commit 74a08b9 into apache:main Mar 3, 2022
shukun-ziqiangxu pushed a commit to shukun-ziqiangxu/tvm that referenced this pull request Mar 6, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants