[Hexagon] Codegen for 2d Load/Store #10586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, a subclass can override GetBufferPtr, without needing to reimplement all of the other indexing logic for BufferLoad/BufferStore.
Previous location in `CodeGenLLVM::BufferAccessHelper` occurred after possible integer wrapping in `indices.size()-1` loop bounds.
kparzysz-quic
approved these changes
Mar 14, 2022
|
Thanks @Lunderberg @kparzysz-quic! |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* Added unit tests for codegen of 2d physical buffers in Hexagon. * Update IndexMap when buffers are updated. * Extended CodeGenLLVM::BufferAccessHelper to support N-d This way, a subclass can override GetBufferPtr, without needing to reimplement all of the other indexing logic for BufferLoad/BufferStore. * Updated CodeGenHexagon to treat 2-d physical buffers as T** * Moved indices size check earlier. Previous location in `CodeGenLLVM::BufferAccessHelper` occurred after possible integer wrapping in `indices.size()-1` loop bounds. * Updated to use `llvm::ArrayRef` instead of `std::vector`. * Resolve lint error. * CI fix, contextlib.nullcontext not available on python3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to add codegen for 2d physical layouts in CodeGenHexagon.
IndexMap.CodeGenLLVM::BufferAccessHelperto allow for N-d buffer access.CodeGenLLVMis still limited to flat 1-d memory buffers, but this allows subclasses to support some forms of N-d buffers by overridingSubclass::CreateBufferPtr.CodeGenHexagon::CreateBufferPtrto allow for 2-d buffer access.