[usmp] U3 use case #11015
Merged
[usmp] U3 use case #11015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-smirnov
force-pushed
the
U3-usecase
branch
4 times, most recently
from
cc86ef9
to
f0a6b67
Compare
d-smirnov
force-pushed
the
U3-usecase
branch
8 times, most recently
from
cc24d4b
to
f538729
Compare
manupak
requested changes
Jun 24, 2022
There was a problem hiding this comment.
Thanks @d-smirnov . The implementation seems good!
I had few concerns and hope they would be minor ones to address.
Added unit test for InterfaceCNode::EmitConstantPool method
|
Thanks @d-smirnov -- This is merged now! |
21 tasks
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* U3 Change-Id: Ibc088f19ad1dc9466fc368f8523baa30ee88b7d0 * addressed upstream comments * Unit test added Added unit test for InterfaceCNode::EmitConstantPool method
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* U3 Change-Id: Ibc088f19ad1dc9466fc368f8523baa30ee88b7d0 * addressed upstream comments * Unit test added Added unit test for InterfaceCNode::EmitConstantPool method
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* U3 Change-Id: Ibc088f19ad1dc9466fc368f8523baa30ee88b7d0 * addressed upstream comments * Unit test added Added unit test for InterfaceCNode::EmitConstantPool method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tir.constant U3 use case functionality allowing user to supply own set of constants to constant pools. TVM provides macros with length and data for user to supply this to the runner.