-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Use r5.large nodes for builds and lint #11258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
requested changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me except for the rogue pip install
😸 The branch build has passed ci_lint
so I think this is going to work!
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
This reverts commit e06cdcf.
areusch
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Mousius
approved these changes
May 11, 2022
Thanks @driazati! |
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
May 16, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
shingjan
pushed a commit
to shingjan/tvm
that referenced
this pull request
May 17, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
juda
pushed a commit
to juda/tvm
that referenced
this pull request
Jun 21, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
r5.large
for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of #11120. Oncetask_cpp_unittest.sh
is fixed so it picks up sccache we can enable these smaller nodes there as well.Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
cc @Mousius @areusch