Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Use r5.large nodes for builds and lint #11258

Merged
merged 4 commits into from
May 11, 2022
Merged

Conversation

driazati
Copy link
Member

@driazati driazati commented May 9, 2022

This uses r5.large for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of #11120. Once task_cpp_unittest.sh is fixed so it picks up sccache we can enable these smaller nodes there as well.

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

cc @Mousius @areusch

Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me except for the rogue pip install 😸 The branch build has passed ci_lint so I think this is going to work!

tests/scripts/task_lint.sh Outdated Show resolved Hide resolved
@driazati driazati requested a review from Mousius May 10, 2022 17:53
@github-actions github-actions bot requested a review from areusch May 10, 2022 17:53
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mousius Mousius merged commit 025c3a3 into apache:main May 11, 2022
@Mousius
Copy link
Member

Mousius commented May 11, 2022

Thanks @driazati!

mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request May 16, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
shingjan pushed a commit to shingjan/tvm that referenced this pull request May 17, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
SebastianBoblest pushed a commit to SebastianBoblest/tvm that referenced this pull request May 27, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
juda pushed a commit to juda/tvm that referenced this pull request Jun 21, 2022
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of apache#11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants