[Hexagon] moves conftest.py to tvm.contrib.hexagon so outside repos can access the testing fixtures #11277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kparzysz-quic
approved these changes
May 11, 2022
mehrdadh
requested changes
May 13, 2022
Lunderberg
reviewed
May 13, 2022
farshidsp
force-pushed
the
farshidsp/hexagon/cleanup_directory
branch
from
a848229
to
29762b9
Compare
mehrdadh
approved these changes
May 19, 2022
| @@ -26,7 +26,7 @@ | |||
| from tvm.contrib.hexagon.session import Session | |||
| from tvm.testing.usmp import is_tvm_backendallocworkspace_calls | |||
|
|
|||
| from .conftest import requires_hexagon_toolchain | |||
There was a problem hiding this comment.
let's change this to require_hexagon in a follow up PR.
juda
pushed a commit
to juda/tvm
that referenced
this pull request
Jun 21, 2022
…an access the testing fixtures (apache#11277) * adding pytest_plugin to python so other repos can access * import requires_hexagon_toolchain from tvm.contrib.hexagon.pytest_plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied the content of
conftest.pytotvm.contrib.hexagon.pytest_plugin--> Outside repos can now access the hexagon specific fixtures.Modified the
conftest.pyto only import thetvm.contrib.hexagon.pytest_pluginModified all the hexagon tests to import
requires_hexagon_toolchainfromtvm.contrib.hexagon.pytest_plugin@Lunderberg @mehrdadh @csullivan