Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNNL][CBLAS][BYOC] Unifles all MKLDNN/DNNL to DNNL #11638

Merged
merged 4 commits into from
Jun 10, 2022
Merged

[DNNL][CBLAS][BYOC] Unifles all MKLDNN/DNNL to DNNL #11638

merged 4 commits into from
Jun 10, 2022

Conversation

Qianshui-Jiang
Copy link
Contributor

We now have USE_MKLDNN (for cblas with matmul/dense) and USE_DNNL_CODEGEN (for DNNL/OneDNN with matmal/dense/conv2d .etc in BYOC ).

Essentially MKL-DNN was discarded by Intel and updated as DNNL (aka Intel OneDNN), as part of Intel OneAPI ,
so this PR mainly focus on deprecate MKL-DNN and use DNNL for both cases (e.g., -libs and BYOC), include:

  • Unified the config.cmake flags USE_MKLDNN and USE_DNNL_CODEGEN to USE_DNNL， setup USE_DNNL can make both -libs and dnnl_codegen(json runtime) enabled.

  • Update all the symbol like mkldnn to dnnl in codes.

Some issue in Rust code not been updated, since tvm_build 0.2.4 should be updated first, we also updated here in tvm_build

This was referenced Jun 9, 2022
Merged
Merged
@Qianshui-Jiang
Copy link
Contributor Author

@masahi @areusch could you pls take a review and comments if need to be refined?

@masahi
Copy link
Member

masahi commented Jun 9, 2022

This seems like a breaking change for users using -libs=mkldnn. Can you still support -libs=mkldnn but translate that to -libs=dnnl?

@Qianshui-Jiang
Copy link
Contributor Author

This seems like a breaking change for users using -libs=mkldnn. Can you still support -libs=mkldnn but translate that to -libs=dnnl?

Sure, good idea.
Does it need to emit a reminding log that we are moving to new flag of dnnl at the same time we supporting -libs=mkldnn?

@masahi
Copy link
Member

masahi commented Jun 9, 2022

Does it need to emit a reminding log that we are moving to new flag of dnnl at the same time we supporting -libs=mkldnn?

yeah let's do that.

@Qianshui-Jiang
Copy link
Contributor Author

@masahi I commit a change of tvm target, pls take a look ,
and could you pls merge #11571 at first so that I can update them all toghther in this PR

@Qianshui-Jiang
Copy link
Contributor Author

Qianshui-Jiang commented Jun 10, 2022 •
edited
Loading

Does it need to emit a reminding log that we are moving to new flag of dnnl at the same time we supporting -libs=mkldnn?

yeah let's do that.

Rebased and updated them all, can you take a look ? let me know if anything need to be changed. :)

@masahi masahi merged commit 705993e into apache:main Jun 10, 2022
juda pushed a commit to juda/tvm that referenced this pull request Jun 21, 2022
@Qianshui-Jiang
[DNNL][CBLAS][BYOC] Unifles all MKLDNN/DNNL to DNNL (apache#11638)
23d9fc8 
* unifies all MKLDNN/DNNL_CODEGEN to DNNL

* translate -lib=mkldnn to -libs=dnnl in target

* type check added before

* rebase and update conv2d from mkldnn to dnnl
@Qianshui-Jiang Qianshui-Jiang deleted the unified_mkldnn_dnnl branch June 26, 2022 09:17
@Qianshui-Jiang Qianshui-Jiang restored the unified_mkldnn_dnnl branch June 26, 2022 09:22
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
@billishyahao billishyahao mentioned this pull request Jul 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Qianshui-Jiang @masahi