Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix python setup.py file bug #12000

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Conversation

Codle
Copy link
Contributor

@Codle Codle commented Jul 3, 2022

Signed-off-by: Zhengqiang Yin codle@outlook.com

The data_files filed in setup_kwargs seems only allow file path rather than dir path. I try to use os.walk to find all the files and re-set them to the data_files filed. This works fine for me and someone else.

Related issue is : #11726

Signed-off-by: Zhengqiang Yin <codle@outlook.com>
@Codle
Copy link
Contributor Author

Codle commented Jul 3, 2022

I'm a little confused about choosing the corresponding reviewers for this PR. I'm sorry if this mention disturbed you, and please help me correct it. Thanks a lot.

@junrushao1994 @yongsun @ezyang

python/setup.py Outdated Show resolved Hide resolved
python/setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once passes CI, happy for this to be merged.

@kparzysz-quic kparzysz-quic merged commit af4373f into apache:main Jul 7, 2022
driazati pushed a commit that referenced this pull request Jul 12, 2022
* fix setup.py bug

Signed-off-by: Zhengqiang Yin <codle@outlook.com>

* remove data_files field

* keep a init setup_kwargs
driazati pushed a commit that referenced this pull request Jul 12, 2022
* fix setup.py bug

Signed-off-by: Zhengqiang Yin <codle@outlook.com>

* remove data_files field

* keep a init setup_kwargs
driazati pushed a commit that referenced this pull request Jul 12, 2022
* fix setup.py bug

Signed-off-by: Zhengqiang Yin <codle@outlook.com>

* remove data_files field

* keep a init setup_kwargs
driazati pushed a commit that referenced this pull request Jul 12, 2022
* fix setup.py bug

Signed-off-by: Zhengqiang Yin <codle@outlook.com>

* remove data_files field

* keep a init setup_kwargs
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
* fix setup.py bug

Signed-off-by: Zhengqiang Yin <codle@outlook.com>

* remove data_files field

* keep a init setup_kwargs
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
* fix setup.py bug

Signed-off-by: Zhengqiang Yin <codle@outlook.com>

* remove data_files field

* keep a init setup_kwargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants