[NNVM][TOPI] Add FTVMCompute for matmul #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhynes
changed the title
tqchen
requested changes
Jun 12, 2018
nnvm/python/nnvm/top/nn.py
Outdated
| @@ -73,6 +73,9 @@ def schedule_dense(_, outs, target): | |||
|
|
|||
| reg.register_pattern("dense", OpPattern.OUT_ELEMWISE_FUSABLE) | |||
|
|
|||
| #matmul | |||
| reg.register_pattern("matmul", OpPattern.INJECTIVE) | |||
There was a problem hiding this comment.
Matmul is unlikely going to be injective, it should be OUT_ELEMWISE_FUSABLE, but the current set of schedule does not support this well. Consider change it to OUT_ELEMWISE_FUSABLE for now and use schedule injective
nnvm/src/top/tensor/matrix_op.cc
Outdated
| const Array<Tensor>& out_info) { | ||
| const MatMulParam& param = nnvm::get<MatMulParam>(attrs.parsed); | ||
| return Array<Tensor>{ | ||
| topi::matmult(inputs[0], inputs[1], param.transpose_a, param.transpose_b) |
There was a problem hiding this comment.
topi::matmult was an API that need to be updated to topi::matmul
tqchen
added
status: review in progress
status: need update
tqchen
approved these changes
Jun 26, 2018
tqchen
added
status: accepted
and removed
status: need update
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
mnuyens
pushed a commit
to mnuyens/tvm
that referenced
this pull request
Jul 10, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of hard to define the gradient in terms of the forward operator without having an implementation thereof ;)