Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPENCL][TEXTURE] Test case enhancements and fixes for RPC #13408

Merged
merged 3 commits into from
Nov 19, 2022
Merged

[OPENCL][TEXTURE] Test case enhancements and fixes for RPC #13408

merged 3 commits into from
Nov 19, 2022

Conversation

srkreddy1238
Copy link
Contributor

RPC execution fails some times when opened multiple times per test case. Making remote object initialized from pytest session instead.

Network test cases added.

dtypes enhanced to support multiple inputs.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 16, 2022 •
edited

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

[OPENCL][TEXTURE] Test case enhancements and fixes for RPC
86bb810 
RPC execution fails some times when opened multiple times per test case.
Making remote object initialized from pytest session instead.

Network test cases added.

dtypes enhanced to support multiple inputs.
echuraev
echuraev reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements! Thank you. One question

python/tvm/relay/frontend/tflite.py
@@ -1549,7 +1549,7 @@ def convert_gather(self, op):
assert axis < data_dim, "Axis out of bounds"

if self.has_expr(indices.tensor_idx):
indices_expr = self.get_expr(indices.tensor_idx)
indices_expr = _op.cast(self.get_expr(indices.tensor_idx), "int32")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this _op.cast?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a bug I encountered while importing other tflite models.

Those models not added here as they are time consuming, but planning to add them to benchmarking scripts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leandron, @AndrewZhaoLuo, @masahi I have doubts, should the test be added for this change or not?
Other changes LGTM.

echuraev
echuraev approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@srkreddy1238 srkreddy1238 requested review from echuraev, junrushao and masahi and removed request for echuraev November 18, 2022 01:20
junrushao
junrushao approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao junrushao merged commit 1ff6e99 into apache:main Nov 19, 2022
@junrushao
Copy link
Member

I'm not 100% sure, but seems like since the merge of the PR, the testcase below consistently fails for some reason:

Test / unittest: GPU 2 of 3 / test_mobilenet_v1_fp32[opencl -device=adreno] - ctypes.tests.python.relay.opencl_texture.test_network

i can submit a PR to temporarily skip the test, but would you guys mind taking a look?

@junrushao
Copy link
Member

junrushao commented Nov 19, 2022 •
edited

xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@srkreddy1238 @xinetzone
[OPENCL][TEXTURE] Test case enhancements and fixes for RPC (apache#13408
feff659 
)

RPC execution fails some times when opened multiple times per test case.
Making remote object initialized from pytest session instead.

Network test cases added.

dtypes enhanced to support multiple inputs.

Co-authored-by: Siva Rama Krishna Reddy B <sivb@blr-ubuntu-ripper.qualcomm.com>
@leandron leandron mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echuraev echuraev echuraev approved these changes

@junrushao junrushao junrushao approved these changes

@masahi masahi Awaiting requested review from masahi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srkreddy1238 @tvm-bot @junrushao @echuraev