-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RPC] Fix tracker connection termination #13420
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
b560753
to
55cca31
Compare
55cca31
to
6153200
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please carefully update all using of the updated functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* [RPC] Fix tracker connection termination * [RPC] Unify work with random key * additional usage of the random_key API change
In a wireless connection situation (android example below) we have a device key containing a colon character(:).
ANDROID_SERIAL_NUMBER = 192.168.0.143:5555
In this case we get an error:
For example, test_rpc_tracker_via_proxy hangs if the device key format contains a colon.
The point is that the keys before using the split have a format like:
conn.put_value has: hexagon-dev.127.0.0.1:5555:0.513619
_tracker_pending_puts has: 127.0.0.1:5555:0.2809967317812382