[TIR] Add preserve_unit_iters option to blockize/tensorize #13579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
github-actions
bot
requested review from
junrushao,
masahi and
spectrometerHBH
shingjan
reviewed
Dec 8, 2022
| @@ -427,7 +430,8 @@ Stmt MakeLoopNest(Stmt stmt, const std::vector<const ForNode*>& loops) { | |||
| } | |||
|
|
|||
| BlockRealize BlockizeImpl(const ScheduleState& self, const StmtSRef& loop_sref, | |||
| Map<Block, Block>* block_sref_reuse, arith::Analyzer* analyzer) { | |||
| bool preserve_unit_iters, Map<Block, Block>* block_sref_reuse, | |||
There was a problem hiding this comment.
nit: put preserve_unit_iters at the end of argument like other functions with preserve_unit_iters introduced.
| @@ -74,16 +74,16 @@ def vnni_conv2d_nchwc_0(placeholder: T.Buffer[(1, 4, 56, 56, 16), "uint8"], plac | |||
| for i0_0, i1_0, i2_0, i3_0, i4_0_0, i0_1, i1_1, i2_1, i3_1, i4_0_1 in T.grid(1, 8, 28, 56, 1, 1, 2, 1, 1, 1): | |||
| for i5_0, i6_0, i7_0, i8_0, i9_0_0, i0_2, i1_2, i2_2, i3_2, i4_0_2, i5_1, i6_1, i7_1, i8_1, i9_0_1, i0_3, i1_3, i2_3, i3_3, i4_0_3 in T.grid(1, 1, 1, 4, 1, 1, 1, 2, 1, 1, 1, 1, 4, 1, 1, 1, 1, 1, 1, 1): | |||
| with T.block("conv2d_NCHWc_int8_o"): | |||
| n = T.axis.spatial(1, 0) | |||
| n = T.axis.spatial(1, i0_2 + i0_3 + i0_0 + i0_1) | |||
There was a problem hiding this comment.
This is the result of trivial iters being preserved instead of simplified right?
vinx13
force-pushed
the
feat/blockize-preserve-unit-iters
branch
from
58e99d6
to
28af660
Compare
vinx13
force-pushed
the
feat/blockize-preserve-unit-iters
branch
from
28af660
to
d0ef417
Compare
shingjan
approved these changes
Dec 8, 2022
masahi
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added an option
preserve_unit_itersto blockize and tensorize, which helps to maintain stability of the loop structure during tuning. It also added an optionsimplify_trivial_iteratortoSubspaceDivide, similar to what's already supported inDetectIterMap.cc @junrushao @spectrometerHBH @masahi
fixed #13517