Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NNVM][TENSORFLOW] Fixed variable ops shape parsing issue #1381

Merged
merged 2 commits into from
Jul 5, 2018

Conversation

joyalbin
Copy link
Contributor

@joyalbin joyalbin commented Jul 4, 2018

This PR will fix the shape parsing issue with Variable ops (eg: VariableV2)
VariableV2 ops converted to Const will have only 'value' attribute

@joyalbin joyalbin changed the title fixed variable ops shape parsing issue [NNVM][TENSORFLOW] Fixed variable ops shape parsing issue Jul 4, 2018
@tqchen
Copy link
Member

tqchen commented Jul 5, 2018

Thanks for the PR, please request reviews from the reviewers

Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

@joyalbin
Copy link
Contributor Author

joyalbin commented Jul 5, 2018

@Huyuwei @masahi @FrozenGene please help to review

@tqchen tqchen merged commit 106bbb8 into apache:master Jul 5, 2018
tqchen pushed a commit to tqchen/tvm that referenced this pull request Jul 6, 2018
mnuyens pushed a commit to mnuyens/tvm that referenced this pull request Jul 10, 2018
sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants