[NNVM][TOP] broadcast versions corresponding to topi: mod, max, min, pow, left_shift, right_shift greater, less, equal, not_equal, greater_equal and less_equal. #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, pow left_shift, right_shift greater, less
srkreddy1238
changed the title
|
@zhreshold @masahi welcome for a review. |
masahi
approved these changes
Jul 5, 2018
|
@masahi thanks for the review. |
masahi
requested changes
Jul 5, 2018
There was a problem hiding this comment.
@srkreddy1238 ok, please add test case for all new ops you introduced.
srkreddy1238
changed the title
|
@masahi ready for review now. Thanks |
|
thanks @masahi for the helpful reviews, thanks @srkreddy1238 for the contribution, this is now merged! |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
…pow, left_shift, right_shift greater, less, equal, not_equal, greater_equal and less_equal. (apache#1383)
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
…pow, left_shift, right_shift greater, less, equal, not_equal, greater_equal and less_equal. (apache#1383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.