Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPI] Add GPU SSD #1397

Merged
merged 19 commits into from
Jul 8, 2018
Merged

[TOPI] Add GPU SSD #1397

merged 19 commits into from
Jul 8, 2018

Conversation

Laurawly
Copy link
Contributor

@Laurawly Laurawly commented Jul 7, 2018

This PR adds the following ops:
nms including GPU sorting
multibox_prior for GPUs
and multibox_detection

Tests for individual ops can be found in topi/tests/python/test_topi_vision.py

@tqchen @kevinthesun @yzhliu @yidawang plz help review or comment, thanks!

@liangfu
Copy link
Member

liangfu commented Jul 7, 2018

Supporting vision operators for gpu is great. But it is less flexible with another copy of operators written with ir_builder. Is it possible to create schedules for IR? Or as suggested in #1322, vision operators should be migrated to use hybrid script? If these are not possible, a rewrite of the IR is fine.

@kevinthesun
Copy link
Contributor

kevinthesun commented Jul 7, 2018

We will migrate ssd related ops to hydrid frontend. IR builder version serves for the first stable version to support ssd on GPU.

@tqchen
Copy link
Member

tqchen commented Jul 8, 2018

@were @srkreddy1238 please review

@tqchen tqchen merged commit 633b13b into apache:master Jul 8, 2018
@tqchen
Copy link
Member

tqchen commented Jul 8, 2018

Thanks @Laurawly for the contribution, this is now merged

tqchen pushed a commit to tqchen/tvm that referenced this pull request Aug 4, 2018
sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants