[TVM] Fixed SPIR-V codegen incorrectly not declaring the interface for the entry point #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Here is a possibly better way to do so:
|
tqchen
added
status: need update
tqchen
requested changes
Jul 9, 2018
src/codegen/spirv/ir_builder.cc
Outdated
| } | ||
|
|
||
| void IRBuilder::CommitKernelFunction(const Value& func_id, const std::string& name) { | ||
| //if (uses_workgroup_id) { |
There was a problem hiding this comment.
Done, noticed those just after committing. They are removed from the latest commit
tqchen
approved these changes
Jul 9, 2018
tqchen
added
status: accepted
and removed
status: need update
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
…r the entry point (apache#1400)
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
…r the entry point (apache#1400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SPIR-V codegen was not generating code compliant with the spec, which was manifesting in all of the vulkan unit tests failing on Windows 10 with a GTX 960 GPU. Specifically, whenever a vulkan kernel was invoked, it would only ever succeed in updating the first element of the input tensor.
This turned out to be due to the codegen not generating the
interfacelist ofOpEntryPoint. For the code that TVM generates, theinterfacelist should contain both the workgroup id and the local invocation id. See https://www.khronos.org/registry/spir-v/specs/1.0/SPIRV.html#OpEntryPoint for details.SPIRV-Tools has recently been updated to detect this situation (see KhronosGroup/SPIRV-Tools#1589), so one way to verify that TVM is generating correct code is to take the output of
get_source, usespirv-asto generate a binary SPIR-V file, and then run a recent release ofspirv-valon the binary file.The fix in this PR does solve the problem, but I'm not sure if it's the best way of addressing this, so I'm definitely open to suggestions on how this could be done better (99% of this PR was tracking down the bug in the first place!)