Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoScheduler][AutoTVM] Enable xgboost >= 1.7.x new changes #14036

Merged
merged 1 commit into from Feb 19, 2023
Merged

[AutoScheduler][AutoTVM] Enable xgboost >= 1.7.x new changes #14036

merged 1 commit into from Feb 19, 2023

Conversation

cbalint13
Copy link
Contributor

@cbalint13 cbalint13 commented Feb 18, 2023

This PR enables tvm to work with newer xgboost >= 1.7.x

Tested with booth AutoTVM and AutoSchedule.

All credits goes to @Sunny-Island
Thanks Jiabei !

Cc @Sunny-Island , @zxybazh @junrushao
also Cc @driazati for CI xgboost>=1.7.x changes

Thanks,
~Cristian.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 18, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@cbalint13 cbalint13 changed the title Enable xgboost >= 1.7.x new changes. Enable xgboost >= 1.7.x new changes Feb 18, 2023
@cbalint13 cbalint13 changed the title Enable xgboost >= 1.7.x new changes [CI][MetaSchedule][AutoTVM] Enable xgboost >= 1.7.x new changes Feb 18, 2023
@tqchen
Copy link
Member

tqchen commented Feb 18, 2023

thanks @cbalint13 can you make the xgboost be compatible to both APIs and send in the xgboost change in? This way we do not have to block on ci update

@cbalint13
Copy link
Contributor Author

thanks @cbalint13 can you make the xgboost be compatible to both APIs and send in the xgboost change in? This way we do not have to block on ci update

@tqchen ,

Sure, lets make it compatible with anything xgboost>=1.1.0 up to latest 1.7.4 (as of this date).

@tqchen tqchen changed the title [CI][MetaSchedule][AutoTVM] Enable xgboost >= 1.7.x new changes [MetaSchedule][AutoTVM] Enable xgboost >= 1.7.x new changes Feb 18, 2023
@zxybazh zxybazh changed the title [MetaSchedule][AutoTVM] Enable xgboost >= 1.7.x new changes [AutoScheduler][AutoTVM] Enable xgboost >= 1.7.x new changes Feb 18, 2023
@tqchen
Copy link
Member

tqchen commented Feb 18, 2023

The android error is not related to this PR. Because check is not dependent on this, i can merge after other CI becomes green

@cbalint13
Copy link
Contributor Author

cbalint13 commented Feb 18, 2023

@tqchen , @zxybazh,

Saw the approval a bit late, meanwhile I just re-pushed PR (very same code, no changes).
I worried due to the failing "CI Android (pull_request)" a unrelated, maybe a temporary CI failure.

To sum the current state:

  • All CI test was in green (except Android) at time of approval.
  • The actual code is 1:1 same with the moment of approval.

I stop right here unless explicit code change is requested.

Thanks,
~Cristian.

@junrushao
Copy link
Member

I noticed similar flakiness on Android earlier today, which is unlikely relevant to your change. Don’t worry about it. We will merge it in ASAP

@tqchen tqchen merged commit 7249904 into apache:main Feb 19, 2023
@tqchen
Copy link
Member

tqchen commented Feb 19, 2023

Thanks @cbalint13

@cbalint13
Copy link
Contributor Author

Thanks @cbalint13

All credits goes to @Sunny-Island
Thanks Jiabei !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants