Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCKER] Add docker demo image #1404

Merged
merged 1 commit into from
Jul 9, 2018
Merged

[DOCKER] Add docker demo image #1404

merged 1 commit into from
Jul 9, 2018

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Jul 9, 2018

@tqchen tqchen merged commit a57de99 into apache:master Jul 9, 2018
tmoreau89
tmoreau89 reviewed Jul 9, 2018
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

tmoreau89
tmoreau89 reviewed Jul 9, 2018
View reviewed changes
docs/install/docker.rst
Docker Images
=============
We provide several prebuilt docker images to quickly try out tvm.
These images are also helpful to do demo/tutorials of TVM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"do demo/tutorials of TVM" -> "run through TVM demo and tutorials"

tmoreau89
tmoreau89 reviewed Jul 9, 2018
View reviewed changes
docs/install/from_source.rst
cmake ..
make -j4

If everything goes well, we can go to the specific language installation section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add reference/hyperlink

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I merged this in before seeing your comment, can you send a PR to add the fix you mentioned?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are minor cosmetic changes to the doc - so I won't be PRing those.

tqchen added a commit to tqchen/tvm that referenced this pull request Aug 4, 2018
@tqchen
[DOCKER] Add docker demo image (apache#1404)
f927e1f
sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018
@tqchen @sergei-mironov
[DOCKER] Add docker demo image (apache#1404)
9c643c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmoreau89 tmoreau89 tmoreau89 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tqchen @tmoreau89