Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unity][IR] Purity Tracking #14394

Merged
merged 73 commits into from
May 18, 2023
Merged

[Unity][IR] Purity Tracking #14394

merged 73 commits into from
May 18, 2023

Commits on May 18, 2023

  1. Preliminary work

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1168c6f View commit details
    Browse the repository at this point in the history

  2. Won't try to infer purity for now

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e4bae67 View commit details
    Browse the repository at this point in the history

  3. Rename pure field to purity

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8ba3041 View commit details
    Browse the repository at this point in the history

  4. Use attrs to annotate function purity

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    33b992d View commit details
    Browse the repository at this point in the history

  5. Start implementing purity tracking

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b7b5685 View commit details
    Browse the repository at this point in the history

  6. Add purity into pretty printer for FuncStructInfo

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ecd85c9 View commit details
    Browse the repository at this point in the history

  7. Process purity when parsing function declarations

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    15f864e View commit details
    Browse the repository at this point in the history

  8. Annotate purity for remaining operators

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ca5aacf View commit details
    Browse the repository at this point in the history

  9. Whitespace

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b10f3cf View commit details
    Browse the repository at this point in the history

  10. More whitespace and remove outdated comment

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ee8bf11 View commit details
    Browse the repository at this point in the history

  11. More linting fixes

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    7181b4f View commit details
    Browse the repository at this point in the history

  12. One more fixed comment

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d6a4800 View commit details
    Browse the repository at this point in the history

  13. Handle purity in the AST printer

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1c94524 View commit details
    Browse the repository at this point in the history

  14. Ensure we are parsing an Expr before checking for an attribute

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d288c31 View commit details
    Browse the repository at this point in the history

  15. Mark purity for remaining ops

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    29f01fe View commit details
    Browse the repository at this point in the history

  16. Factor out repeated call_pure unwrapping

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    34a6c80 View commit details
    Browse the repository at this point in the history

  17. Add purity wrappers and annotations in test_vm_build

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e5c9da5 View commit details
    Browse the repository at this point in the history

  18. One more WrapCallPure in vm_shape_lower

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    82a62b3 View commit details
    Browse the repository at this point in the history

  19. Handle call_pure in memory planning

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    c485ed2 View commit details
    Browse the repository at this point in the history

  20. One more simplification

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e8b0132 View commit details
    Browse the repository at this point in the history

  21. Handle call_pure in one more case

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    62d8852 View commit details
    Browse the repository at this point in the history

  22. Fix struct info analysis test: cannot pass an opaque (impure) functio… 

    …n where a pure one is expected
    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    f843689 View commit details
    Browse the repository at this point in the history

  23. Transfer over StructInfo in the call_pure wrappers

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    07b55e2 View commit details
    Browse the repository at this point in the history

  24. Make corrections to some VM shape lower tests

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    7da2125 View commit details
    Browse the repository at this point in the history

  25. Add transformation to disable purity checking at low levels of compil… 

    …ation
    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4e52206 View commit details
    Browse the repository at this point in the history

  26. Remove purity checking before low-level passes, revert changes

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3932d4e View commit details
    Browse the repository at this point in the history

  27. Also revert changes to VM code generation

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e4d9b6a View commit details
    Browse the repository at this point in the history

  28. Fix VMShapeLower tests

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d005a55 View commit details
    Browse the repository at this point in the history

  29. Fix TVMScript printer test

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    7cc7ef7 View commit details
    Browse the repository at this point in the history

  30. Fix TVMScript parser test

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e8c8365 View commit details
    Browse the repository at this point in the history

  31. Add special handling for printing call_pure, print, and assert_op

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b9fff59 View commit details
    Browse the repository at this point in the history

  32. Fix tests in test_transform.py

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d89ff7d View commit details
    Browse the repository at this point in the history

  33. Remove purity checking in test_codegen_dnnl.py

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    407547b View commit details
    Browse the repository at this point in the history

  34. Add purity annotation for tensor_to_shape

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    0b1f667 View commit details
    Browse the repository at this point in the history

  35. Handle call_pure in FuseTIR

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    00316de View commit details
    Browse the repository at this point in the history

  36. Be more discerning about inserting call_pure in LegalizeOps

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    6ee5773 View commit details
    Browse the repository at this point in the history

  37. Fix various tests to account for purity

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    2a5cafe View commit details
    Browse the repository at this point in the history

  38. Add ForcePure annotations in the static memory planning tests

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b51824c View commit details
    Browse the repository at this point in the history

  39. Add purity annotation for stop_lift_params

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    66bee84 View commit details
    Browse the repository at this point in the history

  40. Insert call_pure in LambdaLift for invoking closures

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1239a36 View commit details
    Browse the repository at this point in the history

  41. Fix outdated comment in test

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4df0097 View commit details
    Browse the repository at this point in the history

  42. Need ToNonDataflow to keep everything consistent

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    511dbfb View commit details
    Browse the repository at this point in the history

  43. Missing call_pure for a BindParams test

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d995686 View commit details
    Browse the repository at this point in the history

  44. Preserve purity in RunCodegen

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    88324c4 View commit details
    Browse the repository at this point in the history

  45. Address changes during rebase

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3c2eeeb View commit details
    Browse the repository at this point in the history

  46. Rebase fixes and add purity annotations for new ops

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4326188 View commit details
    Browse the repository at this point in the history

  47. Fix docstring for contains_impure_call

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    7d6cd1d View commit details
    Browse the repository at this point in the history

  48. Remove manipulate ops tests that are intentionally not supported

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    99102aa View commit details
    Browse the repository at this point in the history

  49. Address TODO: At least one builtin is impure

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1d42358 View commit details
    Browse the repository at this point in the history

  50. Replace call_pure with call_pure_packed, call_pure_dps_packed, invoke… 

    …_pure_closure
    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ddc15db View commit details
    Browse the repository at this point in the history

  51. Formatting

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    cc128ab View commit details
    Browse the repository at this point in the history

  52. Correct rebase errror

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    382e467 View commit details
    Browse the repository at this point in the history

  53. Address dynamic_strided_slice

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    419a021 View commit details
    Browse the repository at this point in the history

  54. Linting: Remove unused import

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4c9d28f View commit details
    Browse the repository at this point in the history

  55. Fix incorrect purity annotations

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    51a5d42 View commit details
    Browse the repository at this point in the history

  56. Fix incorrect comment in well_formed

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b91878e View commit details
    Browse the repository at this point in the history

  57. Add explanatory comment in unusual test case

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1387180 View commit details
    Browse the repository at this point in the history

  58. Use call_pure_packed in pipeline test

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    cd8675a View commit details
    Browse the repository at this point in the history

  59. Update transform_fuse_ops test

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    f26eedb View commit details
    Browse the repository at this point in the history

  60. Use ForcePure for the CUDA graph rewrite

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    697919d View commit details
    Browse the repository at this point in the history

  61. Update comment

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e00ba5c View commit details
    Browse the repository at this point in the history

  62. Factor out search for purity annotation

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    fdb3370 View commit details
    Browse the repository at this point in the history

  63. Remove call_dps_pure_packed (call_dps_packed is pure) and remove wrap… 

    …ping/unwrapping behavior
    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    0fa4843 View commit details
    Browse the repository at this point in the history

  64. Remove unused var

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    446d863 View commit details
    Browse the repository at this point in the history

  65. Correct rebase mistake

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    587ba5f View commit details
    Browse the repository at this point in the history

  66. Use ForcePure for tests of low-level codegen

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ba78ec4 View commit details
    Browse the repository at this point in the history

  67. lint

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    85d5f62 View commit details
    Browse the repository at this point in the history

  68. Make LazyTransformParams compatible with purity tracking

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    f1982f5 View commit details
    Browse the repository at this point in the history

  69. Make is_pure and force_pure fields in Function instead of attrs

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d83bfbb View commit details
    Browse the repository at this point in the history

  70. Lint

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3ba972f View commit details
    Browse the repository at this point in the history

  71. Unused imports

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3616ec0 View commit details
    Browse the repository at this point in the history

  72. Use an attribute (relax.force_pure) to control forcing purity

    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e786f92 View commit details
    Browse the repository at this point in the history

  73. Indicate that RemovePurityChecking is also required for LazyTransform… 

    …Params
    @slyubomirsky
    slyubomirsky committed May 18, 2023
    Configuration menu
    Copy the full SHA
    c920bf5 View commit details
    Browse the repository at this point in the history