Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPPORT] Fix RingBuffer ReadWithCallback #14743

Merged
merged 2 commits into from
May 10, 2023
Merged

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Apr 28, 2023

This PR bugfixes ring buffer ReadWithCallback when the callback send function read part of the data.
Also backported one robustness fix from unity.

Testcases are added

@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 28, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: support See #10317 for details

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junrushao
Copy link
Member

Looks like there is a CI outage

@tqchen
Copy link
Member Author

tqchen commented May 1, 2023

@tvm-bot rerun

This PR bugfixes ring buffer ReadWithCallback when
the callback send function read part of the data.
Also backported one robustness fix from unity.

Testcases are added
@tqchen
Copy link
Member Author

tqchen commented May 3, 2023

@tvm-bot rerun

@junrushao
Copy link
Member

@tvm-bot rerun

2 similar comments
@tqchen
Copy link
Member Author

tqchen commented May 7, 2023

@tvm-bot rerun

@tqchen
Copy link
Member Author

tqchen commented May 8, 2023

@tvm-bot rerun

@junrushao junrushao merged commit a1c1cca into apache:main May 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants