[NNVM][DARKNET]Logistic activation added #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PariksheetPinjari909 @srkreddy1238 Could you please help review this PR. Thanks |
PariksheetPinjari909
suggested changes
Jul 25, 2018
nnvm/python/nnvm/frontend/darknet.py
Outdated
| @@ -323,6 +325,8 @@ def _darknet_activations(inputs, attrs): | |||
| sym = _darknet_get_nnvm_op(op_name)(*inputs, **new_attrs) | |||
| elif act_type in ['elu']: | |||
| sym = -1 * _sym.relu(1 - _sym.exp(*inputs)) + _sym.relu(*inputs) | |||
| elif act_type in ['logistic']: | |||
| sym = 1 / (1 + _sym.exp(*inputs * (-1))) | |||
There was a problem hiding this comment.
_sym.sigmoid function can be used here.
| @@ -324,6 +324,32 @@ def test_forward_rnn(): | |||
| test_rnn_forward(net) | |||
| LIB.free_network(net) | |||
|
|
|||
| def test_forward_activation_logistic(): | |||
| '''test elu activation layer''' | |||
There was a problem hiding this comment.
Pls correct comment elu to logistic activation
siju-samuel
force-pushed
the
darknet_logistic
branch
from
e3e7489
to
47922d3
Compare
|
@PariksheetPinjari909 Thanks for reviewing. I modified according to your comments. Please check. |
|
Thanks @siju-samuel @PariksheetPinjari909 ! this is now merged |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logistic activation support is added for darknet, which is needed for a C-RNN model.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.