[BUILD] warning fix: new does not have an alignment parameter #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please also check if the compiler itself is g++ as we can also use clang |
tqchen
requested changes
Jul 25, 2018
CMakeLists.txt
Outdated
| @@ -78,6 +78,9 @@ else(MSVC) | |||
| check_cxx_compiler_flag("-std=c++11" SUPPORT_CXX11) | |||
| set(CMAKE_C_FLAGS "-O2 -Wall -fPIC ${CMAKE_C_FLAGS}") | |||
| set(CMAKE_CXX_FLAGS "-O2 -Wall -fPIC -std=c++11 ${CMAKE_CXX_FLAGS}") | |||
| if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 7.0) | |||
There was a problem hiding this comment.
Need to confirm if compiler is g++, otherwise the rule is not correct fo clang
There was a problem hiding this comment.
@tqchen I have used 'g++' compiler (cc1plus) and warnings are seen.
I verified build with 'clang' and not seen the these warnings.
Shall I add check for 'g++' here?
There was a problem hiding this comment.
yes, please only trigger this flag when compiler is g++
tqchen
approved these changes
Jul 27, 2018
|
Thanks @joyalbin ! This is now merged |
tqchen
added
status: accepted
and removed
status: need update
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below warning is shown with environment GCC 7.2 and -std=c++11
This PR will fix the below warnings tvm/vta/src/sim/sim_driver.cc: In constructor _vta::sim::DRAM::Page::Page(size_t, size_t)_: tvm/vta/src/sim/sim_driver.cc:196:33: warning: _new_ of type _vta::sim::DRAM::Page::DType {aka std::aligned_storage<4096, 256> ::type}_ with extended alignment 256 [-Waligned-new=] data = new DType[num_pages]; ^ tvm/vta/src/sim/sim_driver.cc:196:33: note: uses _void* operator new [](std::size_t)_, which does not have an alignment parameter tvm/vta/src/sim/sim_driver.cc:196:33: note: use _-faligned-new_ to enable C++17 over-aligned new support tvm/vta/src/sim/sim_driver.cc: In instantiation of _vta::sim::SRAM<kBits, kLane, kMaxNumElem>::SRAM() [with int kBits = 8; int kLane = 256; int kMaxNumElem = 1024]_: tvm/vta/src/sim/sim_driver.cc:345:12: required from here tvm/vta/src/sim/sim_driver.cc:226:13: warning: _new_ of type _vta::sim::SRAM<8, 256, 1024>::DType {aka std::aligned_storage<25 6, 256>::type}_ with extended alignment 256 [-Waligned-new=] data_ = new DType[kMaxNumElem]; ^~~~~~~~~~~~~~~~~~~~~~ tvm/vta/src/sim/sim_driver.cc:226:13: note: uses _void* operator new [](std::size_t)_, which does not have an alignment parameter tvm/vta/src/sim/sim_driver.cc:226:13: note: use _-faligned-new_ to enable C++17 over-aligned new support tvm/vta/src/sim/sim_driver.cc: In instantiation of _vta::sim::SRAM<kBits, kLane, kMaxNumElem>::SRAM() [with int kBits = 32; in t kLane = 16; int kMaxNumElem = 2048]_: tvm/vta/src/sim/sim_driver.cc:345:12: required from here tvm/vta/src/sim/sim_driver.cc:226:13: warning: _new_ of type _vta::sim::SRAM<32, 16, 2048>::DType {aka std::aligned_storage<64 , 64>::type}_ with extended alignment 64 [-Waligned-new=] tvm/vta/src/sim/sim_driver.cc:226:13: note: uses _void* operator new [](std::size_t)_, which does not have an alignment parameter tvm/vta/src/sim/sim_driver.cc:226:13: note: use _-faligned-new_ to enable C++17 over-aligned new supportThis PR will avoid the issue
Reference: https://github.com/google/flatbuffers/pull/4621/files