Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] Move SplitHostDevice to before MakePackedAPI #14986

Merged

Conversation

Lunderberg
Copy link
Contributor

This simplifies the logic used in MakePackedAPI, as it is now the last user of the host parameter in a function's target. After MakePackedAPI, every PrimFunc has a "target" attribute without a "host".

This is part of a series of commits to simplify the handling of multi-target builds.

@tvm-bot
Copy link
Collaborator

tvm-bot commented May 30, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Lunderberg
Copy link
Contributor Author

This PR is a subset of the changes introduced in #14862, split out for ease of testing and reviewing. It is currently a draft PR, as it interacts with the same functionality that is being fixed in #14982, and should probably re-run CI to avoid a similar breakage being reintroduced.

While I've tested this PR against the specific VTA failure that is #14982 fixes, we may want to re-run CI on top of main to avoid similar breakage.

This simplifies the logic used in MakePackedAPI, that it the last user
of the host parameter in a function's target.  After MakePackedAPI,
every PrimFunc has a "target" attribute without a "host".
@Lunderberg Lunderberg force-pushed the split_host_device_before_packed_api branch from 4d1df64 to c31f2b0 Compare June 5, 2023 03:03
@Lunderberg Lunderberg marked this pull request as ready for review June 5, 2023 16:32
@Lunderberg
Copy link
Contributor Author

Lunderberg commented Jun 6, 2023

@tvm-bot rerun

(All CI tests passing, failure in CI/Windows due to a network connection dropping.)

@Hzfengsy Hzfengsy merged commit 56255f8 into apache:main Jun 8, 2023
18 of 19 checks passed
@Lunderberg Lunderberg deleted the split_host_device_before_packed_api branch June 8, 2023 11:27
junrushao pushed a commit to junrushao/tvm that referenced this pull request Jun 22, 2023
* [TIR] Move SplitHostDevice to before MakePackedAPI

This simplifies the logic used in MakePackedAPI, that it the last user
of the host parameter in a function's target.  After MakePackedAPI,
every PrimFunc has a "target" attribute without a "host".

* Roofline plots, update location for SaveLoweredTIR

* Update ethos-u tests to include host prior to MakeUnpackedAPI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants