Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NNVM][DARKNET]Yolo and Upsample frontend support #1501

Merged
merged 5 commits into from Aug 20, 2018

Conversation

PariksheetPinjari909
Copy link
Contributor

This PR adds NNVM front-end support for Yolo and Up-sample op

@PariksheetPinjari909 PariksheetPinjari909 changed the title Yolo and Upsample frontend support [NNVM][DARKNET]Yolo and Upsample frontend support Jul 27, 2018
@PariksheetPinjari909
Copy link
Contributor Author

@zhreshold @srkreddy1238 Pls review this. TIA

@@ -55,7 +55,7 @@
# Download and Load darknet library
# ---------------------------------

darknet_lib = 'libdarknet.so'
darknet_lib = 'libdarknet2.0.so'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to provide lib for Mac and windows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to give steps to generate this lib from source instead (Many platforms and lot of compilers).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binaries can be build from sources and can be imported to run the model. For demo purpose, i will update the binaries for Mac and Windows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can we find the build scripts for compiling this library?

@yzhliu
Copy link
Member

yzhliu commented Aug 6, 2018

Please rebase according to #1394
Sorry for the inconvenience

@PariksheetPinjari909 PariksheetPinjari909 force-pushed the yolo_upsample branch 2 times, most recently from a6fdc28 to 3fb9ac0 Compare August 9, 2018 03:36
@PariksheetPinjari909
Copy link
Contributor Author

Currently darknet is not supported on windows platform. I have updated the mac lib for darknet.
@zhreshold @srkreddy1238 Pls review

@zhreshold
Copy link
Member

@PariksheetPinjari909 Understand, LGTM

@yzhliu
Copy link
Member

yzhliu commented Aug 15, 2018

@PariksheetPinjari909 Please rebase and resolve the conflict, thanks!

@PariksheetPinjari909
Copy link
Contributor Author

@yzhliu @tqchen Conflicts are resolved now. Pls check

@PariksheetPinjari909
Copy link
Contributor Author

@yzhliu @tqchen Can you pls review and merge this PR before another conflict. Thanks.

@tqchen tqchen merged commit 4dc21bd into apache:master Aug 20, 2018
siju-samuel added a commit to siju-samuel/tvm that referenced this pull request Sep 3, 2018
The recent changes in tutorial is with PR # apache#1501 broken the link for downloading the weights file, leading to this CI failure.
tqchen pushed a commit that referenced this pull request Sep 3, 2018
The recent changes in tutorial is with PR # #1501 broken the link for downloading the weights file, leading to this CI failure.
ZhennanQin pushed a commit to ZhennanQin/tvm that referenced this pull request Sep 6, 2018
The recent changes in tutorial is with PR # apache#1501 broken the link for downloading the weights file, leading to this CI failure.
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
* Yolo and Upsample frontend support

* Lint fix

* Mac support added

* Code clean and trigger CI
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
The recent changes in tutorial is with PR # apache#1501 broken the link for downloading the weights file, leading to this CI failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants