New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NNVM][DARKNET]Yolo and Upsample frontend support #1501
Conversation
@zhreshold @srkreddy1238 Pls review this. TIA |
tutorials/nnvm/from_darknet.py
Outdated
@@ -55,7 +55,7 @@ | |||
# Download and Load darknet library | |||
# --------------------------------- | |||
|
|||
darknet_lib = 'libdarknet.so' | |||
darknet_lib = 'libdarknet2.0.so' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to provide lib for Mac and windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to give steps to generate this lib from source instead (Many platforms and lot of compilers).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Binaries can be build from sources and can be imported to run the model. For demo purpose, i will update the binaries for Mac and Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where can we find the build scripts for compiling this library?
Please rebase according to #1394 |
a6fdc28
to
3fb9ac0
Compare
3fb9ac0
to
74d1ed0
Compare
Currently darknet is not supported on windows platform. I have updated the mac lib for darknet. |
@PariksheetPinjari909 Understand, LGTM |
@PariksheetPinjari909 Please rebase and resolve the conflict, thanks! |
The recent changes in tutorial is with PR # apache#1501 broken the link for downloading the weights file, leading to this CI failure.
The recent changes in tutorial is with PR # #1501 broken the link for downloading the weights file, leading to this CI failure.
The recent changes in tutorial is with PR # apache#1501 broken the link for downloading the weights file, leading to this CI failure.
* Yolo and Upsample frontend support * Lint fix * Mac support added * Code clean and trigger CI
The recent changes in tutorial is with PR # apache#1501 broken the link for downloading the weights file, leading to this CI failure.
This PR adds NNVM front-end support for Yolo and Up-sample op