Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU][ETHOSU] Fix SoftMax legalization parameters #15069

Merged

Conversation

Aleksei-grovety
Copy link
Contributor

@Aleksei-grovety Aleksei-grovety commented Jun 9, 2023

Fix SoftMax legalization parameters according to the values in Vela.

cc @neildhickey, @lhutton1, @ekalda, @leandron

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jun 9, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Aleksei-grovety! I'm wondering if there could be a test included that exercises this change?

@Aleksei-grovety Aleksei-grovety changed the title [microNPU][ETHOSU] Fix Softmax activation parameters [microNPU][ETHOSU] Fix SoftMax legalization parameters Jun 20, 2023
@Aleksei-grovety
Copy link
Contributor Author

I checked the output of the generated commands in TVM and Vela and updated legalization test accordingly.

@Aleksei-grovety Aleksei-grovety force-pushed the ethosu-fix-softmax-activation-parameters branch from 91bc9ca to d55ebb0 Compare June 23, 2023 13:34
@lhutton1
Copy link
Contributor

@tvm-bot rerun

@lhutton1 lhutton1 merged commit 28aead9 into apache:main Jun 26, 2023
18 checks passed
@lhutton1
Copy link
Contributor

Thanks @Aleksei-grovety @ekalda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants