[TVMScript] Avoid visiting repetition tensor in SetCommonPrefix Visitor #15083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
Hi, @Hzfengsy @junrushao . All test cases passed, please help to review this patch. |
|
Thanks for the PR! To make sure I completely understand this change: it adds a flag to each field to avoid double visiting. Did I get it right? |
junrushao
reviewed
Jun 14, 2023
src/script/printer/ir_docsifier.cc
Outdated
| @@ -134,6 +141,7 @@ void IRDocsifierNode::SetCommonPrefix(const ObjectRef& root, | |||
|
|
|||
| ReflectionVTable* vtable_ = ReflectionVTable::Global(); | |||
| std::vector<const Object*> stack_; | |||
| std::vector<const Object*> visited_; | |||
There was a problem hiding this comment.
Do you want to switch to std::unordered_set instead?
There was a problem hiding this comment.
Okay, std::unordered_set is well.
|
Yeah, you are right. |
junrushao
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the issue about:
[Bug] [TVMScript] Progress hang on lowerTE during build dynamic Relay IR caused by endless ReprPrintTIR. #15048