[TIR][TVMScript] Convert tir.op operands to PrimExpr #15091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some operations in
tvm.tir.op
required the operand to already be aPrimExpr
, and raised an error if the operand was instead a python object. This could cause failures round-trip through TVMScript, as int32 and float32 types are printed as literals in TVMScript, relying on automatic conversion to convert them back intoPrimExpr
objects. For example,T.expr2(T.int32(0))
is printed asT.expr2(0)
, which then passes the python object0
intotvm.tir.op.expr2
when parsing the TVMScript.This commit updates the operations in
tvm.tir.op
to convert operands prior to accessingoperand.dtype
, avoiding the error and allowing these expressions to round-trip.This issue was first noticed in #15076 for
T.ret(0)
, but applied to any operator that used the operand's dtype without first normalizing toPrimExpr
.