Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM] Minor refactor to LLVMModuleNode::SaveToFile #15139

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[LLVM] Minor refactor to LLVMModuleNode::SaveToFile #15139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
78 changes: 40 additions & 38 deletions src/target/llvm/llvm_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,57 +180,59 @@ PackedFunc LLVMModuleNode::GetFunction(const String& name, const ObjectPtr<Objec
return WrapPackedFunc(faddr, sptr_to_self);
}

void LLVMModuleNode::SaveToFile(const String& file_name_str, const String& format) {
std::string file_name = file_name_str;
std::string fmt = runtime::GetFileFormat(file_name, format);
std::error_code ecode;
namespace {
#if TVM_LLVM_VERSION <= 70
llvm::raw_fd_ostream dest(file_name, ecode, llvm::sys::fs::F_None);
constexpr auto llvm_open_output_flag = llvm::sys::fs::F_None;
#else
llvm::raw_fd_ostream dest(file_name, ecode, llvm::sys::fs::OF_None);
constexpr auto llvm_open_output_flag = llvm::sys::fs::OF_None;
#endif
ICHECK_EQ(ecode.value(), 0) << "Cannot open file: " << file_name << " " << ecode.message();
if (fmt == "o" || fmt == "obj") {
With<LLVMTarget> llvm_target(*llvm_instance_, LLVMTarget::GetTargetMetadata(*module_));

#if TVM_LLVM_VERSION <= 60
std::unique_ptr<llvm::Module> m = llvm::CloneModule(module_);
std::unique_ptr<llvm::Module> CloneLLVMModule(llvm::Module* mod) { return llvm::CloneModule(mod); }
#else
std::unique_ptr<llvm::Module> m = llvm::CloneModule(*module_);
std::unique_ptr<llvm::Module> CloneLLVMModule(llvm::Module* mod) { return llvm::CloneModule(*mod); }
#endif
llvm::legacy::PassManager pass;
llvm::TargetMachine* tm = llvm_target->GetOrCreateTargetMachine();
#if TVM_LLVM_VERSION <= 60
ICHECK(tm->addPassesToEmitFile(pass, dest, llvm::TargetMachine::CGFT_ObjectFile) == 0)
<< "Cannot emit target CGFT_ObjectFile";
#elif TVM_LLVM_VERSION <= 90
ICHECK(tm->addPassesToEmitFile(pass, dest, nullptr, llvm::TargetMachine::CGFT_ObjectFile) == 0)
<< "Cannot emit target CGFT_ObjectFile";

#if TVM_LLVM_VERSION <= 90
constexpr auto llvm_object_file_target = llvm::TargetMachine::CGFT_ObjectFile;
constexpr auto llvm_assembly_file_target = llvm::TargetMachine::CGFT_AssemblyFile;
#else
ICHECK(tm->addPassesToEmitFile(pass, dest, nullptr, llvm::CGFT_ObjectFile) == 0)
<< "Cannot emit target CGFT_ObjectFile";
constexpr auto llvm_object_file_target = llvm::CGFT_ObjectFile;
constexpr auto llvm_assembly_file_target = llvm::CGFT_AssemblyFile;
#endif
pass.run(*m);
} else if (fmt == "s" || fmt == "asm") {
With<LLVMTarget> llvm_target(*llvm_instance_, LLVMTarget::GetTargetMetadata(*module_));

bool LLVMAddPassesToEmitFile(llvm::TargetMachine* tm, llvm::legacy::PassManager* pm,
llvm::raw_fd_ostream* dest,
decltype(llvm_object_file_target) llvm_file_target) {
#if TVM_LLVM_VERSION <= 60
std::unique_ptr<llvm::Module> m = llvm::CloneModule(module_);
return tm->addPassesToEmitFile(*pm, *dest, llvm_file_target);
#else
std::unique_ptr<llvm::Module> m = llvm::CloneModule(*module_);
return tm->addPassesToEmitFile(*pm, *dest, nullptr, llvm_file_target);
#endif
}

} // namespace

void LLVMModuleNode::SaveToFile(const String& file_name_str, const String& format) {
// CHECK(imports_.empty()) << "SaveToFile does not handle imported modules";
std::string file_name = file_name_str;
std::string fmt = runtime::GetFileFormat(file_name, format);
std::error_code ecode;
llvm::raw_fd_ostream dest(file_name, ecode, llvm_open_output_flag);
ICHECK_EQ(ecode.value(), 0) << "Cannot open file: " << file_name << " " << ecode.message();
bool is_obj_file = fmt == "o" || fmt == "obj";
bool is_asm_file = fmt == "s" || fmt == "asm";
if (is_obj_file || is_asm_file) {
auto llvm_file_target = is_obj_file ? llvm_object_file_target : llvm_assembly_file_target;

With<LLVMTarget> llvm_target(*llvm_instance_, LLVMTarget::GetTargetMetadata(*module_));
llvm::legacy::PassManager pass;
llvm::TargetMachine* tm = llvm_target->GetOrCreateTargetMachine();
#if TVM_LLVM_VERSION <= 60
ICHECK(tm->addPassesToEmitFile(pass, dest, llvm::TargetMachine::CGFT_AssemblyFile) == 0)
<< "Cannot emit target CGFT_AssemblyFile";
#elif TVM_LLVM_VERSION <= 90
ICHECK(tm->addPassesToEmitFile(pass, dest, nullptr, llvm::TargetMachine::CGFT_AssemblyFile) ==
0)
<< "Cannot emit target CGFT_AssemblyFile";
#else
ICHECK(tm->addPassesToEmitFile(pass, dest, nullptr, llvm::CGFT_AssemblyFile) == 0)
<< "Cannot emit target CGFT_AssemblyFile";
#endif
pass.run(*m);

auto err = LLVMAddPassesToEmitFile(tm, &pass, &dest, llvm_file_target);
ICHECK(!err) << "Cannot emit target CGFT_ObjectFile";

pass.run(*CloneLLVMModule(module_));
} else if (fmt == "ll") {
module_->print(dest, nullptr);
} else if (fmt == "bc") {
Expand Down