[Runtime] Clean TVM stacktrace in error messages #15161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
tqchen
approved these changes
Jun 27, 2023
tqchen
reviewed
Jun 27, 2023
include/tvm/runtime/logging.h
Outdated
| @@ -367,11 +367,7 @@ class LogFatal { | |||
| this->lineno_ = lineno; | |||
| } | |||
| [[noreturn]] TVM_NO_INLINE dmlc::Error Finalize() { | |||
| InternalError error(file_, lineno_, stream_.str()); | |||
| #if DMLC_LOG_BEFORE_THROW | |||
There was a problem hiding this comment.
keep LOG_BEFORE_THROW guard as it is useful for windows
|
one minor nit |
This PR introduces some cleanups on the stacktraces in TVM's error message by removing the meaningless frames, for example, C++ template dispatch with `std::enable_if`.
junrushao
force-pushed
the
feature/2023-06-26/clean-stacktrace
branch
from
cbfb8b1
to
ff2c059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some cleanups on the stacktraces in TVM's error message by removing the meaningless frames, for example, C++ template dispatch with
std::enable_if.