Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM] Check the output of microNPU demos in CI #15667

Merged
merged 2 commits into from Sep 6, 2023

Conversation

lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented Sep 4, 2023

This is a followup from #15649 which caught a misclassification issue when running the microNPU demo. While #15649 fixes the issue and results in the correct classification, this commit ensures the demo does not regress again in the future.

cc @ashutosh-arm @leandron

This is a followup from apache#15649 which caught a misclassification
issue when running the microNPU demo. While apache#15649 fixes the issue
and results in the correct classification, this commit ensures the
demo does not regress again in the future.

Change-Id: I816bb7dbba92cf447ff66f26ff881e1586740b6a
Copy link
Contributor

@ashutosh-arm ashutosh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhutton1 for catching this. I have added few queries.

tests/scripts/task_demo_microtvm.sh Outdated Show resolved Hide resolved
tests/scripts/task_demo_microtvm.sh Outdated Show resolved Hide resolved
Change-Id: I2cb25dce1e76890e3c72707146cccf0e43dc5456
Copy link
Contributor

@ashutosh-arm ashutosh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Appreciate the effort. Thanks!

@lhutton1 lhutton1 merged commit 5d3f3dd into apache:main Sep 6, 2023
19 checks passed
@lhutton1 lhutton1 deleted the check-demo branch September 6, 2023 14:09
@lhutton1
Copy link
Contributor Author

lhutton1 commented Sep 6, 2023

Thanks @ashutosh-arm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants