Revert "[CodeGenC] Handle GlobalVar callee as internal function call" #15725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related discussion: #15103 (comment). |
MasterJH5574
approved these changes
Sep 12, 2023
|
Thank you @junrushao! @Lunderberg I’m sorry for this. Please help take a look at the issue! |
junrushao
force-pushed
the
revert-15103-codegen_c_support_subroutine_calls
branch
from
2902c10
to
cf1766c
Compare
|
Prior to merging I would request that we please include a test or otherwise link to a test that fails so that there is something semi-minimal for which can be used to support the desired use case and prevent the breakage in the future. |
|
Agreed @csullivan. Given it's a codegen test, it's a bit challenging though to have a minimal test if we don't have unittest infra that could potentially access Metal-capable devices. As suggested by @MasterJH5574 in the prior thread, how about using tests in |
junrushao
force-pushed
the
revert-15103-codegen_c_support_subroutine_calls
branch
from
cf1766c
to
45eb402
Compare
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Sep 14, 2023
As a first step to addressing the Metal codegen errors that required the reversion in apache#15725, parametrizing the unit tests for `allreduce`. While these tests are parametrized with `@tvm.testing.parametrize_targets("cuda", "metal")`, the automatic `tvm.testing.requires_metal` marker inserted for the metal parametrization will cause them to be skipped if the metal runtime is unavailable, which includes the current CI.
Hzfengsy
pushed a commit
that referenced
this pull request
Sep 15, 2023
* [UnitTest][Metal] Parametrize allreduce GPU tests As a first step to addressing the Metal codegen errors that required the reversion in #15725, parametrizing the unit tests for `allreduce`. While these tests are parametrized with `@tvm.testing.parametrize_targets("cuda", "metal")`, the automatic `tvm.testing.requires_metal` marker inserted for the metal parametrization will cause them to be skipped if the metal runtime is unavailable, which includes the current CI. * Updated filename, device used when testing on metal
junrushao
deleted the
revert-15103-codegen_c_support_subroutine_calls
branch
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Sep 27, 2023
This reverts commit [`e88d0d`](apache#15725), which itself reverted [`9ff71f`](apache#15103) for breakages on the metal backend. Now that the CI contains compile-time testing of the metal codegen, the original breakage should be identifiable.
csullivan
pushed a commit
that referenced
this pull request
Oct 18, 2023
…15835) * [CodeGenC][Redo] Handle GlobalVar callee as internal function call This reverts commit [`e88d0d`](#15725), which itself reverted [`9ff71f`](#15103) for breakages on the metal backend. Now that the CI contains compile-time testing of the metal codegen, the original breakage should be identifiable. * Added codegen metal CI debug print * Print function decl to the argument stream * Remove the codegen metal CI debug print-outs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily reverts a recent change that breaks the Metal backend. Happy to get this commit back once the codegen is fixed.
Reverts #15103