[Unity] Update relax_dynamo #15962
Merged
[Unity] Update relax_dynamo #15962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tvm-bot rerun |
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/6602009999 with response |
Hzfengsy
reviewed
Oct 22, 2023
| @@ -35,6 +35,28 @@ def device_from_inputs(example_inputs): | |||
| return None | |||
|
|
|||
|
|
|||
| def get_fake_inputs(graph_module, example_inputs): | |||
There was a problem hiding this comment.
Please write type annotations and docstring for this function
There was a problem hiding this comment.
Thanks for your comment. Regarding these type annotations from Torch, I don't think it is appropriate to import torch at the file header solely for adding annotations, as shown below.
tvm/python/tvm/relax/frontend/torch/dynamo.py
Lines 52 to 55 in 1ba11f6
There was a problem hiding this comment.
I see. Would you be able to make it a private function? i.e. put it inside the function relax_dynamo?
| result = input1[ | ||
| torch.arange(1), | ||
| ] | ||
| result = input1[torch.arange(1),] |
There was a problem hiding this comment.
style. Keep it remain unchanged or
Suggested change
| result = input1[torch.arange(1),] | |
| result = input1[torch.arange(1)] |
liquanfeng
force-pushed
the
dynamo
branch
2 times, most recently
from
af9d2a8
to
6fee5ff
Compare
|
@tvm-bot rerun |
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/6607831952 with response |
|
Thanks @liquanfeng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch 2.1.0 has switched the calling convention to real tensors (pytorch/pytorch#99320), consequently prompting an update of the
relax_dynamowith real tensors.Additionally, there is a new dynamic dynamo test from Pytorch Docs that generates dead code in the fx graph, requiring the application of
eliminate_dead_code.cc @Hzfengsy @MasterJH5574