Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[microNPU][ETHOSU] Fix ConcatRewriter args processing #16003

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[microNPU][ETHOSU] Fix ConcatRewriter args processing #16003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tvm/relay/backend/contrib/ethosu/legalize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,7 @@ def callback(
# Find the tensors that are inputs to the concat and the scales and zero points
concat_args = list()
for arg in post.args:
if isinstance(arg, tvm.relay.expr.Call):
if isinstance(arg, (tvm.relay.expr.Call, tvm.relay.expr.TupleGetItem)):
concat_args.append(arg)

axis = post.op.body.attrs.axis
Expand Down
16 changes: 16 additions & 0 deletions tests/python/contrib/test_ethosu/test_codegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,6 +1170,22 @@ def concat_func(*inputs):
infra.compare_tvm_with_tflite(concat_func, shapes, accel_type, enable_cascader=False)


def test_tflite_unstack_concat():
np.random.seed(0)
shapes = [(2, 4, 16)]
axis = 1
accel_type = "ethos-u55-256"

@tf.function
def concat_func(input):
inputs = tf.unstack(input)
inputs.reverse()
op = tf.concat(inputs, axis)
return op

infra.compare_tvm_with_tflite(concat_func, shapes, accel_type, enable_cascader=False)


def test_tflite_concat_with_reused_args():
np.random.seed(0)
shapes = [(1, 1, 24, 1), (1, 1, 24, 1), (1, 1, 10, 1), (1, 1, 68, 1)]
Expand Down