[WebGPU] Add shuffle support for webgpu #16004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delay; will also follow up with other targets' Shuffle later |
|
I sent a PR for shuffle support here #15998 it will work for webgpu, metal and other targets |
|
Ahh I see, closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds shuffle support for WebGPU. Following up on the discussion in #15517, the new field
rewrite_scalar_read_to_vector_shuffleinPointerTypeRewriterequires Shuffle to achieve scalar reads.This resolves the issue described in #15517 (comment).
cc: @vinx13, @tqchen, @MasterJH5574