Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix str vs. int comparison in test_num_threads #16017

Merged
merged 1 commit into from Oct 31, 2023

Conversation

PhilippvK
Copy link
Contributor

If either TVM_NUM_THREADS or OMP_NUM_THREADS the test_num_threads would fail because strings can not be compared with integers.

This tiny PR fixes the test by introducing type casts.

Copy link
Contributor

@quic-sanirudh quic-sanirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@masahi masahi merged commit c4c0a49 into apache:main Oct 31, 2023
19 checks passed
@PhilippvK PhilippvK deleted the fix-num-threads-str branch January 23, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants