[TVMScript] Fix mismatched dtype of IterVar in T.thread_binding
#16041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnson9009
approved these changes
Nov 2, 2023
|
look good to me, Thanks. |
Hzfengsy
force-pushed
the
fix_tvmscript_thread_binding_dtype
branch
from
29a8df7
to
a6eb0dd
Compare
As reported by the [community](https://discuss.tvm.apache.org/t/int32-int64-issue-when-codegen-into-llvm-function/15915), the dtype of IterVar in `T.thread_binding` is not consistent with the dtype of the corresponding IterVar. This PR fixes this issue.
Hzfengsy
force-pushed
the
fix_tvmscript_thread_binding_dtype
branch
from
a6eb0dd
to
4345e32
Compare
Hzfengsy
added a commit
to Hzfengsy/tvm
that referenced
this pull request
Nov 5, 2023
As a follow up PR of apache#16041, this PR fixes the iter_var dtype generated by the schedule primitive `bind`. Now the iter_var dtype is the same as the loop_var. Note that this PR changes the internal interface (tir interface) of the bind primitive. But it does not change the user interface (python side, and concrete_schedule.cc side).
Hzfengsy
added a commit
to Hzfengsy/tvm
that referenced
this pull request
Nov 5, 2023
As a follow up PR of apache#16041, this PR fixes the iter_var dtype generated by the schedule primitive `bind`. Now the iter_var dtype is the same as the loop_var. Note that this PR changes the internal interface (tir interface) of the bind primitive. But it does not change the user interface (python side, and concrete_schedule.cc side).
junrushao
pushed a commit
that referenced
this pull request
Nov 5, 2023
As a follow up PR of #16041, this PR fixes the iter_var dtype generated by the schedule primitive `bind`. Now the iter_var dtype is the same as the loop_var. Note that this PR changes the internal interface (tir interface) of the bind primitive. But it does not change the user interface (python side, and concrete_schedule.cc side).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by the community, the dtype of IterVar in
T.thread_bindingis not consistent with the dtype of the corresponding value. This PR fixes this issue.