Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][TIR] Fix dtype issues for match_buffer and ramp node #16051

Merged
merged 2 commits into from Nov 7, 2023

Conversation

Ubospica
Copy link
Contributor

@Ubospica Ubospica commented Nov 3, 2023

This PR fixes dtype issues for

  • the strides parameter of match_buffer.
    • When stride is a tir var, it would become a string like "A_s0" in the printed script.
    • If the strides are int64 vars, when we parse the printed script, the dtype of the strides will be set to int32 by default. That causes dtype misalign and effects the structural_equal check.
    • We will cast the string stride to the dtype of shape (which is always a primexpr)
  • ramp node. If the dtypes of base and stride of a ramp node do not match, the dtype of stride will be casted to the dtype of base.

@tqchen
Copy link
Member

tqchen commented Nov 6, 2023

@tvm-bot rerun

@tqchen tqchen merged commit df5d3b5 into apache:main Nov 7, 2023
14 checks passed
Ubospica added a commit to Ubospica/tvm-develop that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants