[TIR][Transform] Introduce new InjectPermutedLayout pass
#16070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Hzfengsy,
spectrometerHBH and
vinx13
Ubospica
force-pushed
the
main-dev/2023-11-02-inject-permuted-layout
branch
3 times, most recently
from
73944d2
to
2cbf342
Compare
vinx13
reviewed
Nov 6, 2023
Ubospica
force-pushed
the
main-dev/2023-11-02-inject-permuted-layout
branch
from
2cbf342
to
4905883
Compare
vinx13
approved these changes
Nov 7, 2023
|
@tvm-bot rerun |
1 similar comment
|
@tvm-bot rerun |
yzh119
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new
InjectPermutedLayoutpass, partially adapted from the old version.This pass will permute the visiting indices of the shared memory with xor operations to avoid bank conflicts. For permutation details see p39 of these slides.
The current interface is:
The load/store operation could be:
And the InjectPermutedLayout pass is injected in the lowering process in
driver_api.cc. So after this pass in the building stage, the visiting indices will be permuted.Notably this pass works after the
CompactBufferAllocationpass because it relies on the shape of the shared memory in every threadblock.cc @spectrometerHBH @vinx13 @Hzfengsy