[Unity][Transform] Keep R.ExternFunc in dead-code elimination #16118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `DeadCodeElimination` and `FuseTIR` passes treated `R.ExternFunc` differently with respect to removal of internal functions: `DeadCodeElimination` treated these functions as internal, to be removed if there are no internal callers, while `FuseTIR` treated these functions as external, to be retained in all cases. Because the visibility of a function is determined by the `tvm::attr::kGlobalSymbol` attribute; which is present for `PrimFunc` and `relax::Function`, but missing for `relax::ExternFunc`; there is no information in the `IRModule` that can determine whether a `relax::ExternFunc` should be visible externally. For consistency, and to allow the use of `DeadCodeElimination` in future refactors of `FuseTIR`, this commit updates `DeadCodeElimination` to retain instances of `relax::ExternFunc`.
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
DeadCodeEliminationandFuseTIRpasses treatedR.ExternFuncdifferently with respect to removal of internal functions:DeadCodeEliminationtreated these functions as internal, to be removed if there are no internal callers, whileFuseTIRtreated these functions as external, to be retained in all cases.Because the visibility of a function is determined by the
tvm::attr::kGlobalSymbolattribute; which is present forPrimFuncandrelax::Function, but missing forrelax::ExternFunc; there is no information in theIRModulethat can determine whether arelax::ExternFuncshould be visible externally.For consistency, and to allow the use of
DeadCodeEliminationin future refactors ofFuseTIR, this commit updatesDeadCodeEliminationto retain instances ofrelax::ExternFunc.