[Relay][Frontend][QNN] fix access param_debug_name_map
to node output name in fx-quantized graph node replacement
#16217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem of not finding the key of
param_debug_name_map
with "name", an attribute ofprim::GetAttr
, wheninline_input_quant_params_for_fx
replacingprim::GetAttr
withprim::Constant
. This problem occurs when the model is quantized by each sub-models with quantize_fx, and the zero point and scale variable names are different from the name, the attribute ofprim::GetAttr
. To solve this, when modifying allprim::GetAttr
toprim::Constant
, modify to accessparam_debug_name_map
by using thenode.output.debugName()
. The reason is thatnodes.output().debugName()
as shown pattern like.<number>
at the end of their names, which distinguishes same name and that can be found inparam_debug_name_map
When quantization is performed for each sub-model, different zero point and scale values are calibrated for each layer.
we can find
simple_dense_1_input_zero_point_0.7
inparam_debug_name_map
, but original code recursively find all attribute name in children model, for example,layer.0.simple_dense_1_input_zero_point_0
.param_debug_name_map