[TVMScript] Disable concise scoping when the scope stmt is explicitly annotated #16271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrongtest-intellif
force-pushed
the
disable_concise_scoping_on_annotated_scope_stmt
branch
from
45ec030
to
d329729
Compare
Hzfengsy
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @junrushao @cyx-6
Hi, the change want to disable the concise scoping print on nested scope stmts, when some of the stmt is annotated.
The annotated python comments would disappear since under consice scoping, the stmt is converted to
StmtBlockDocNodewhich would not bind annotations.