Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Check for zero-param operators in LiftTransformParams #16595

Merged
merged 1 commit into from
Feb 29, 2024

Commits on Feb 23, 2024

  1. [Transform] Check for zero-param operators in LiftTransformParams

    Prior to this commit, `LiftTransformParams` would extract out all
    variable binding that have no runtime dependencies.  As a result,
    expressions such as `R.zeros([16], "int32")` would be extracted out
    into the parameter transformation, even though they do not depend on
    any parameters.
    
    This commit updates `LiftTransformParams` to only output variables
    that depend on at least one compile-time parameter.
    
    The unit test for this functionality also found that `relax::Call` was
    erroneously calling `MarkGraphNode` in `SEqualReduce` and
    `SHashReduce`.  This should only be called for nodes that have have
    reference equality, such as `relax::Var`, and not for composite
    objects.  This caused erroneous failures in the unit test when two
    instances of `R.zeros([16], "int32")` were being compared by reference
    equality in `StructuralEqual`.  These extra calls to `MarkGraphNode`
    have been removed.
    Lunderberg committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2390033 View commit details
    Browse the repository at this point in the history