Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass default values to target config/options #17004

Closed
wants to merge 3 commits into from

Conversation

MNGanesan
Copy link
Contributor

BYOC Compiler Config node defines the target compiler's command line options, along with default values.
This change extract the default values while constructing target options for codegen/target compiler.
Added test case for this feature as well.

BYOC Compiler Config node defines the target compiler's
command line optios, along with default values. This change
extract the default values while constructing target options
for codegen/target compiler.
Added test case for this feature as well.

Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
@MNGanesan
Copy link
Contributor Author

MNGanesan commented May 19, 2024

For my PR, cortexm/pr-head test is failing, on investigation I find

boolean type argument of CMSIS-NN is not passed with numeric value and got below error

[2024-05-16T14:29:37.357Z] tvmc compile: error: argument --target-cmsis-nn-debug_last_error: invalid int value: 'False'

Argument passed:

"--target-cmsis-nn-debug_last_error=false"

Based on the python argument parse, above error looks to be valid, however it is not observed other PR.
I could not decipher the link between this error and my PR.

Am able to reproduce this error, if I pass value "false/true" to a boolean, but not for the numeric value "0/1".
As per TVM type, boolean is treated as "int" type , Hence passing the value "false/true" is incorrect and python parser handle it correctly.

Could some one put a light on it ? How it is passing in test of other PRs when python argument parser looks to be valid ?

Appreciate your insights!

M N Ganesan added 2 commits May 20, 2024 17:05
BYOC Compiler Config node defines the target compiler's
command line optios, along with default values. This change
extract the default values while constructing target options
for codegen/target compiler.
Added test case for this feature as well.

Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
…into pass_default_values

Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
@MNGanesan MNGanesan closed this May 21, 2024
@MNGanesan MNGanesan deleted the pass_default_values branch May 21, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant