[TVMScript][Relax] Preserve tir.SizeVar through TVMScript round-trip #17083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, all symbolic variables were printed identically, regardless of whether the underlying variable was a `tir.Var` or `tir.SizeVar`. As a result, numeric simplifications that rely on a `tir.SizeVar` being non-negative may be skipped after a round-trip through TVMScript. This commit updates the TVMScript printing and parsing of Relax functions to use `var = T.int64(is_size_var=True)` for `tir.SizeVar`, matching how `tir.SizeVar` is parsed for TIR functions. As an added benefit, this also allows Relax functions `R.Prim` arguments other than `int64` to be benefit. This may be useful in the future, such as to specify the fill value for `R.full`.
Hzfengsy
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, all symbolic variables were printed identically, regardless of whether the underlying variable was a
tir.Varortir.SizeVar. As a result, numeric simplifications that rely on atir.SizeVarbeing non-negative may be skipped after a round-trip through TVMScript.This commit updates the TVMScript printing and parsing of Relax functions to use
var = T.int64(is_size_var=True)fortir.SizeVar, matching howtir.SizeVaris parsed for TIR functions. As an added benefit, this also allows Relax functionsR.Primarguments other thanint64to be benefit. This may be useful in the future, such as to specify the fill value forR.full.